forms: made profile form configurable #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0einstein0
force-pushed
the
profile-form
branch
2 times, most recently
from
759d517 to
c052a9b
Compare
zzacharo
reviewed
Jan 29, 2025
0einstein0
force-pushed
the
profile-form
branch
from
c052a9b to
ec67762
Compare
kpsherva
reviewed
Feb 5, 2025
| # NOTE: Form field label | ||
| _("Re-enter email address"), | ||
| # NOTE: Form field help text | ||
| description=_("Please re-enter your email address."), |
There was a problem hiding this comment.
nit: it is nice to tell the user why we expect them to do an action, otherwise the description is almost the same as the field label
Suggested change
| description=_("Please re-enter your email address."), | |
| description=_("Please re-enter your email address to make sure the provided address is correct."), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Closes Issue zenodo/zenodo-rdm#1103
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: